[Azure Monitor AspNetCore] Plumb EnableStandardMetrics and EnablePerfCounters#56438
Merged
Conversation
mattsains-msft
requested review from
harsimar,
rajkumar-rangaraj and
xiang17
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes the Azure Monitor Exporter configuration flags EnableStandardMetrics and EnablePerfCounters through the Azure.Monitor.OpenTelemetry.AspNetCore distribution, and verifies the values flow through DI configuration into AzureMonitorExporterOptions.
Changes:
- Added
EnableStandardMetricsandEnablePerfCounterstoAzureMonitorOptionswith default values and XML docs. - Plumbed the new option values into
AzureMonitorExporterOptionsviaSetValueToExporterOptions. - Added unit tests covering defaults, disabling, and propagation through
UseAzureMonitor(...)DI configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorOptions.cs | Adds the two public options and copies them into exporter options during configuration. |
| sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Tests/AzureMonitorOptionsTests.cs | Adds tests verifying defaults and end-to-end propagation into AzureMonitorExporterOptions. |
rajkumar-rangaraj
approved these changes
Feb 24, 2026
This was referenced May 1, 2026
Open
Bump Azure.Extensions.AspNetCore.Configuration.Secrets from 1.3.1 to 1.5.1
khoinguyennn/eShopOnWeb#5
Open
This was referenced May 6, 2026
Open
Open
Bump Azure.Extensions.AspNetCore.Configuration.Secrets from 1.3.2 to 1.5.1
ayoubnur-dev/eShopOnWeb#9
Open
Open
Open
Bump Azure.Extensions.AspNetCore.Configuration.Secrets from 1.3.2 to 1.5.1
seahawkjerry/eShopOnWeb#9
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the recently-made-public config options EnableStandardMetrics and EnablePerfCounters of Azure Monitor Exporter into the AspNetCore distribution.